Error Handling: refactor ExecuteComputation and ExecuteReplicated to propagate status.
#9445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ysiraichi
force-pushed
the
ysiraichi/status-for-oom-eager-mode
branch
2 times, most recently
from
bb72d7f to
8f1ba5e
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-oom-errors
branch
3 times, most recently
from
34abde6 to
103cd0f
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-oom-eager-mode
branch
from
8f1ba5e to
d3e373e
Compare
ysiraichi
changed the base branch from
ysiraichi/status-for-oom-errors
to
master
ysiraichi
force-pushed
the
ysiraichi/status-for-oom-eager-mode
branch
from
50f33b9 to
4c3616a
Compare
qihqi
approved these changes
Jul 29, 2025
Key changes: - Updated base `ComputationClient` interface to return `absl::StatusOr<std::vector<DataPtr>>` - Modified IFRT and PjRt implementations to use proper error propagation - Replaced raw `.value()` calls with `XLA_ASSIGN_OR_RETURN_WITH_LOCATION` macros - Updated all call sites to use `GetValueOrThrow` for exception-based error handling
ysiraichi
force-pushed
the
ysiraichi/status-for-oom-eager-mode
branch
from
04bb0d4 to
f3f4d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors both
ComputationClient:::ExecuteComputationandComputationClient:::ExecuteReplicatedfunctions for propagating error statuses.Key Changes:
ExecuteComputationandExecuteReplicated: Now explicitly propagatesabsl::Status..value()Calls: UsesXLA_ASSIGN_OR_RETURNfor propagating the status.GetValueOrThrowfor more robust error management.